Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gc_first_tid #157

Merged
merged 1 commit into from
May 31, 2024
Merged

Fix gc_first_tid #157

merged 1 commit into from
May 31, 2024

Conversation

kpamnany
Copy link
Collaborator

PR Description

The first GC thread's TID was set to the first thread after the default threadpool. When there are interactive threads, this is set incorrectly.

Checklist

Requirements for merging:

  • I have opened an issue or PR upstream on JuliaLang/julia: <link to JuliaLang/julia>
  • I have removed the port-to-* labels that don't apply.
  • I have opened a PR on raicode to test these changes:

@github-actions github-actions bot added port-to-v1.10 This change should apply to Julia v1.10 builds port-to-master This change should apply to all future Julia builds labels May 31, 2024
@kpamnany kpamnany merged commit b882d43 into v1.10.2+RAI May 31, 2024
6 checks passed
@kpamnany kpamnany deleted the kp-fix-gc-first-tid branch May 31, 2024 17:31
Copy link
Member

@d-netto d-netto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

Drvi pushed a commit that referenced this pull request Jun 7, 2024
Drvi pushed a commit that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-master This change should apply to all future Julia builds port-to-v1.10 This change should apply to Julia v1.10 builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants